Log

• Revert "gometalinter: Use interfaces when it makes sense" 💬 by Caio 9 years ago

  This reverts commit 2686af5cd15f0a8f4650e2a4a9bbf44c05b87e10.
  
  I still don't like this even after sleeping on it :-)
  

• Reference `gopkg.in` in the README by Caio 9 years ago
• Add syntax highlighting to the README example 💬 by Caio 9 years ago

  Look at this with the `-w` switch and you'll see that all that
  has changed is that I wrapped the example code with some "```"
  and adjusted the indent.
  

• gometalinter: Use interfaces when it makes sense 💬 by Caio 9 years ago

  There's now another suggestion:
  
      $ gometalinter ./... --disable=gocyclo
      serialization.go:63:16:warning: buf can be jpeg.Reader (interfacer)
  
  But that's just too silly.
  
  To be honest, I'm not so sure this is a sensical change even:
  encodeUint and encodeUint are "private". bytes.{Buffer,Reader} is
  precisely what I need and use throughout the implementation. So,
  hashtag revertMeMaybe.
  

• gometalinter: Error checking on tests 💬 by Caio 9 years ago

  With this patch we now explicitly ignore most errors coming from Add()
  (as there are specialized tests for it and the consistency checks
  cover the error scenario) and introduces a check for potential Merge()
  and Compress() errors.
  
  Not really happy with the mass ignore, but I do like the `errcheck`
  linter, so there's that.
  

• gometalinter: Simplify if-return clause by Caio 9 years ago
• gometalinter: Avoid redefining `c` 💬 by Caio 9 years ago

  Harmless, but an easy fix anyway :)
  

• Add missing error checks 💬 by Caio 9 years ago

  This patch fixes some missing error checks as pointed out by
  `gometalinter` (thanks @dgryski!).
  
  There is a signature change on Merge() and Compress(), from returning
  nothing to now returning an error type.
  

• Remove the gocover.io banner 💬 by Caio 9 years ago

  Too damn unstable for my taste.
  

• Test explicitly against 1.7, drop 1.4 by Caio 9 years ago
• No need for a tmp var to make a swap by Caio 10 years ago
• No more `t.Parallel()` anywhere by Caio 10 years ago
• Stabilize the rng to the Sequential Insertion test 💬 by Caio 10 years ago

  Before this patch I would see the occasional failure when running:
  
      $ go test -run Sequential -count 30
  
  The failures are consistently _not_ on the extreme quantiles, as
  expected given the data-structure characteristics. I guess this is
  because `Add()` and `shuffle()` (which is used by `Compress()`, that
  gets triggered several times for this test given the small summary
  size) use the same rng source, but I'm not even remotely close to
  someone who properly understands all this math.
  
  Shouldn't be a real problem, but I'll consider adding support for
  providing a random source instead of using the default one so that
  at least we get no contention from multiple things asking for a random
  number to the global source.
  

• Revert "Try out this travis-ci + coveralls thing" 💬 by Caio 10 years ago

  This reverts commit 42ef656694f47a21c37295c1ae3446666ee04c1f.
  
  LOL This randomly fails with:
  
      Bad response status from coveralls: 422 - {"message":"Couldn't find
      a repository matching this job.","error":true}
  
  And here shows that there's something real silly going on:
  
      https://github.com/lemurheavy/coveralls-public/issues/487
  
  So no, not worth the pain. $fancy--
  

• Try out this travis-ci + coveralls thing by Caio 10 years ago
• Set count to zero after creating a new summary by Caio 10 years ago
• Assert we don't change counts during Compress() 💬 by Caio 10 years ago

  So that we avoid causing a regression (Ref: PR #10)
  

• Merge pull request #10 from ianwilkes/master 💬 by Caio 10 years ago

  Fix serious accuracy bug and improve performance

• Fix forever-incrementing count which caused inaccurate results after Compress(); eliminate memory allocation when calling findNearestCentroids(); make tests deterministic by removing t.Parallel() (see comments); add more tests by Ian Wilkes 10 years ago
• Enable building against go 1.6 by Caio 10 years ago
• Merge pull request #7 from ajgillis/master 💬 by Caio 10 years ago

  Provide ForEachCentroid() and Len() functins to access internal data.

• ForEachCentroid should not return value, since this makes assumptions about the behavior of the supplied function. by Andrew Gillis 10 years ago
• Provide ForEachCentroid() and Len() functins to access internal data. by Andrew Gillis 10 years ago
• Add link to "go report" 💬 by Caio 10 years ago

  Kool-aid++

• Add tests for the panic() codepaths 💬 by Caio 10 years ago

  Pretty much useless, but I was curious how to test for that. A bit
  awkward at first though it kind of makes sense.
  

• Move serialization tests into serialization_test.go by Caio 10 years ago
• Don't allow a K smaller than 1.0f 💬 by Caio 10 years ago

  For it makes no sense whatsoever.
  

• Add some more docs for tdigest.TDigest by Caio 10 years ago
• Add missing zero from tdigest.New docs 💬 by Caio 10 years ago

  It's 100, not 10.
  

• Get rid of the unused Remove() method by Caio 10 years ago