Ignore messages from known old identities 💬 by Caio 7 months ago (log)
In a scenario where traffic is buffered and/or replayed this could lead to noisy cluster behaviour
In a scenario where traffic is buffered and/or replayed this could lead to noisy cluster behaviour
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 |
/* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ extern crate alloc; use alloc::vec::Vec; use rand::{ prelude::{IteratorRandom, SliceRandom}, Rng, }; /// State describes how a Foca instance perceives a member of the cluster. /// /// This is part of the Suspicion Mechanism described in section 4.2 of the /// original SWIM paper. #[derive(Debug, PartialEq, Eq, Clone, Copy)] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub enum State { /// Member is active. Alive, /// Member is active, but at least one cluster member /// suspects its down. For all purposes, a `Suspect` member /// is treated as if it were `Alive` until either it /// refutes the suspicion (becoming `Alive`) or fails to /// do so (being declared `Down`). Suspect, /// Confirmed Down. /// A member that reaches this state can't join the cluster /// with the same identity until the cluster forgets /// this knowledge. Down, } /// Incarnation is a member-controlled cluster-global number attached /// to a member identity. /// A member M's incarnation starts with zero and can only be incremented /// by said member M when refuting suspicion. pub type Incarnation = u16; /// A Cluster Member. Also often called "cluster update". /// /// A [`Member`] represents Foca's snapshot knowledge about an /// [`crate::Identity`]. An individual cluster update is simply a /// serialized Member which other Foca instances receive and use to /// update their own cluster state representation. #[derive(Debug, Clone, PartialEq, Eq)] #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct Member<T> { id: T, incarnation: Incarnation, state: State, } impl<T> Member<T> { /// Initializes a new member. /// /// `id` is an identity used to uniquely identify an individual /// cluster member (say, a primary key). pub fn new(id: T, incarnation: Incarnation, state: State) -> Self { Self { id, incarnation, state, } } /// Shortcut for initializing a member as [`State::Alive`]. pub fn alive(id: T) -> Self { Self::new(id, Incarnation::default(), State::Alive) } #[cfg(test)] pub(crate) fn suspect(id: T) -> Self { Self::new(id, Incarnation::default(), State::Suspect) } pub(crate) fn down(id: T) -> Self { Self::new(id, Incarnation::default(), State::Down) } /// Getter for the member's Incarnation pub fn incarnation(&self) -> Incarnation { self.incarnation } /// Getter for the member's State pub fn state(&self) -> State { self.state } /// Getter for the member's identity pub fn id(&self) -> &T { &self.id } pub(crate) fn is_active(&self) -> bool { match self.state { State::Alive | State::Suspect => true, State::Down => false, } } pub(crate) fn change_state(&mut self, incarnation: Incarnation, state: State) -> bool { if self.can_change(incarnation, state) { self.state = state; self.incarnation = incarnation; true } else { false } } fn can_change(&self, other_incarnation: Incarnation, other: State) -> bool { // This implements the order of preference of the Suspicion subprotocol // outlined on section 4.2 of the paper. match self.state { State::Alive => match other { State::Alive => other_incarnation > self.incarnation, State::Suspect => other_incarnation >= self.incarnation, State::Down => true, }, State::Suspect => match other { State::Alive | State::Suspect => other_incarnation > self.incarnation, State::Down => true, }, State::Down => false, } } pub(crate) fn into_identity(self) -> T { self.id } } pub(crate) struct Members<T> { pub(crate) inner: Vec<Member<T>>, cursor: usize, num_active: usize, } #[cfg(test)] impl<T> Members<T> { pub(crate) fn len(&self) -> usize { self.inner.len() } } impl<T> Members<T> where T: PartialEq + Clone + crate::Identity, { pub(crate) fn num_active(&self) -> usize { self.num_active } pub(crate) fn new(inner: Vec<Member<T>>) -> Self { // XXX This doesn't prevent someone initializing with // duplicated members... Not a problem (yet?) since // inner is always empty outside of tests let num_active = inner.iter().filter(|member| member.is_active()).count(); Self { cursor: 0, num_active, inner, } } // Next member that's considered active // Chosen at random (shuffle + round-robin) pub(crate) fn next(&mut self, mut rng: impl Rng) -> Option<&Member<T>> { // Round-robin with a shuffle at the end if self.cursor >= self.inner.len() { self.inner.shuffle(&mut rng); self.cursor = 0; } // Find an active member from cursor..len() let position = self .inner .iter() .skip(self.cursor) .position(|m| m.is_active()) // Since we skip(), position() will start counting from zero // this ensures it's actually the index of the chosen member .map(|pos| pos + self.cursor); // And if we don't find any: try from 0..cursor let position = position.or_else(|| { self.inner .iter() .take(self.cursor) .position(|m| m.is_active()) }); if let Some(pos) = position { if pos < self.cursor { // We wrapped around the list to find a member. A shuffle // is needed, so we set it to MAX. Any other value could // cause the shuffle to not happen since members may join // in-between probes self.cursor = core::usize::MAX; } else { self.cursor = pos.saturating_add(1); } self.inner.get(pos) } else { None } } fn choose_members<F>( &self, wanted: usize, output: &mut Vec<Member<T>>, mut rng: impl Rng, picker: F, ) where F: Fn(&Member<T>) -> bool, { // Basic reservoir sampling let mut num_chosen = 0; let mut num_seen = 0; for member in &self.inner { if !picker(member) { continue; } num_seen += 1; if num_chosen < wanted { num_chosen += 1; output.push(member.clone()); } else { let replace_at = rng.gen_range(0..num_seen); if replace_at < wanted { output[replace_at] = member.clone(); } } } } pub(crate) fn choose_down_members( &self, wanted: usize, output: &mut Vec<Member<T>>, rng: impl Rng, ) { self.choose_members(wanted, output, rng, |member| !member.is_active()); } pub(crate) fn choose_active_members<F>( &self, wanted: usize, output: &mut Vec<Member<T>>, rng: impl Rng, picker: F, ) where F: Fn(&T) -> bool, { self.choose_members(wanted, output, rng, |member| { member.is_active() && picker(member.id()) }); } pub(crate) fn remove_if_down(&mut self, id: &T) -> Option<Member<T>> { let position = self .inner .iter() .position(|member| &member.id == id && member.state == State::Down); position.map(|pos| self.inner.swap_remove(pos)) } pub(crate) fn iter_active(&self) -> impl Iterator<Item = &Member<T>> { self.inner.iter().filter(|m| m.is_active()) } pub(crate) fn is_active(&self, id: &T) -> bool { self.inner .iter() .any(|member| &member.id == id && member.is_active()) } pub(crate) fn apply_existing_if<F: Fn(&Member<T>) -> bool>( &mut self, mut update: Member<T>, condition: F, ) -> Option<ApplySummary<T>> { if let Some(known_member) = self .inner .iter_mut() .find(|member| member.id.addr() == update.id().addr()) { // if there's a conflict and the update wins, the member // state is fully replaced let mut force_apply = false; if known_member.id != update.id { // If the update wins the conflict, the full member // state is replaced (it's essentially a rejoin) if known_member.id.win_addr_conflict(&update.id) { // update lost conflict, it's junk return Some(ApplySummary { is_active_now: known_member.is_active(), apply_successful: false, changed_active_set: false, conflict: ConflictResult::Lost, }); } force_apply = true; } if !condition(known_member) { let conflict = if force_apply { ConflictResult::FailedCondition } else { ConflictResult::NoConflict }; return Some(ApplySummary { is_active_now: known_member.is_active(), apply_successful: false, changed_active_set: false, conflict, }); } let was_active = known_member.is_active(); let mut conflict = ConflictResult::NoConflict; let apply_successful = if force_apply { core::mem::swap(&mut known_member.id, &mut update.id); conflict = ConflictResult::Replaced(update.id); known_member.state = update.state; known_member.incarnation = update.incarnation; true } else { known_member.change_state(update.incarnation, update.state) }; let is_active_now = known_member.is_active(); let changed_active_set = is_active_now != was_active; if changed_active_set { // XXX Overzealous checking if is_active_now { self.num_active = self.num_active.saturating_add(1); } else { self.num_active = self.num_active.saturating_sub(1); } } Some(ApplySummary { is_active_now, apply_successful, changed_active_set, conflict, }) } else { None } } pub(crate) fn apply(&mut self, update: Member<T>, mut rng: impl Rng) -> ApplySummary<T> { self.apply_existing_if(update.clone(), |_member| true) .unwrap_or_else(|| { // Unknown member, we'll register it let is_active_now = update.is_active(); // Insert at the end and swap with a random position. self.inner.push(update); let inserted_at = self.inner.len() - 1; let swap_idx = (0..self.inner.len()) .choose(&mut rng) .unwrap_or(inserted_at); self.inner.swap(swap_idx, inserted_at); if is_active_now { self.num_active = self.num_active.saturating_add(1); } ApplySummary { is_active_now, apply_successful: true, // Registering a new active member changes the active set changed_active_set: is_active_now, conflict: ConflictResult::NoConflict, } }) } } #[derive(Debug, Clone, PartialEq)] #[must_use] pub(crate) struct ApplySummary<T> { pub(crate) is_active_now: bool, pub(crate) apply_successful: bool, pub(crate) changed_active_set: bool, pub(crate) conflict: ConflictResult<T>, } #[derive(Debug, Clone, PartialEq)] pub(crate) enum ConflictResult<T> { NoConflict, Replaced(T), Lost, FailedCondition, } #[cfg(test)] mod tests { use crate::Identity; use super::*; use alloc::vec; use rand::{rngs::SmallRng, SeedableRng}; #[derive(Clone, Debug, PartialEq, Eq, Copy, PartialOrd, Ord)] struct Id(&'static str); impl crate::Identity for Id { type Addr = &'static str; fn renew(&self) -> Option<Self> { None } fn addr(&self) -> Self::Addr { self.0 } fn win_addr_conflict(&self, _adversary: &Self) -> bool { panic!("addr is self, there'll never be a conflict"); } } use State::*; #[test] fn alive_transitions() { let mut member = Member::new(Id("a"), 0, Alive); // Alive => Alive assert!( member.change_state(member.incarnation + 1, Alive), "can transition to a higher incarnation" ); assert_eq!(1, member.incarnation); assert_eq!(Alive, member.state); assert!( !member.change_state(member.incarnation - 1, Alive), "cannot transition to a lower incarnation" ); assert!( !member.change_state(member.incarnation, Alive), "cannot transition to same state and incarnation {:?}", &member ); // Alive => Suspect assert!( !member.change_state(member.incarnation - 1, Suspect), "lower suspect incarnation shouldn't transition" ); assert!( member.change_state(member.incarnation, Suspect), "transition to suspect with same incarnation" ); assert_eq!(Suspect, member.state); member = Member::new(Id("b"), 0, Alive); assert!( member.change_state(member.incarnation + 1, Suspect), "transition to suspect with higher incarnation" ); assert_eq!(1, member.incarnation); assert_eq!(Suspect, member.state); // Alive => Down, always works assert!( Member::new("c", 1, Alive).change_state(0, Down), "transitions to down on lower incarnation" ); assert!( Member::new("c", 0, Alive).change_state(0, Down), "transitions to down on same incarnation" ); assert!( Member::new("c", 0, Alive).change_state(1, Down), "transitions to down on higher incarnation" ); } #[test] fn suspect_transitions() { let mut member = Member::new(Id("a"), 0, Suspect); // Suspect => Suspect assert!( member.change_state(member.incarnation + 1, Suspect), "can transition to a higher incarnation" ); assert_eq!(1, member.incarnation); assert_eq!(Suspect, member.state); assert!( !member.change_state(member.incarnation - 1, Suspect), "cannot transition to a lower incarnation" ); assert!( !member.change_state(member.incarnation, Suspect), "cannot transition to same state and incarnation {:?}", &member ); // Suspect => Alive assert!( !member.change_state(member.incarnation - 1, Alive), "lower alive incarnation shouldn't transition" ); assert!( !member.change_state(member.incarnation, Alive), "same alive incarnation shouldn't transition" ); assert!( member.change_state(member.incarnation + 1, Alive), "can transition to alive with higher incarnation" ); assert_eq!(Alive, member.state); // Suspect => Down, always works assert!( Member::new("c", 1, Suspect).change_state(0, Down), "transitions to down on lower incarnation" ); assert!( Member::new("c", 0, Suspect).change_state(0, Down), "transitions to down on same incarnation" ); assert!( Member::new("c", 0, Suspect).change_state(1, Down), "transitions to down on higher incarnation" ); } #[test] fn down_never_transitions() { let mut member = Member::new("dead", 1, Down); for incarnation in 0..=2 { assert!(!member.change_state(incarnation, Alive)); assert!(!member.change_state(incarnation, Suspect)); assert!(!member.change_state(incarnation, Down)); } } #[test] fn next_walks_sequentially_then_shuffles() { let ordered_ids = vec![Id("1"), Id("2"), Id("3"), Id("4"), Id("5")]; let mut members = Members::new(ordered_ids.iter().cloned().map(Member::alive).collect()); let mut rng = SmallRng::seed_from_u64(0xF0CA); for wanted in ordered_ids.iter() { let got = members .next(&mut rng) .expect("Non-empty set of Alive members should always yield Some()") .id; assert_eq!(wanted, &got); } // By now we walked through all known live members so // the internal state should've shuffled. // We'll verify that by calling `next()` multiple // times and comparing with the original `ordered_ids` let mut after_shuffle = (0..ordered_ids.len()) .map(|_| members.next(&mut rng).unwrap().id) .collect::<Vec<_>>(); assert_ne!(ordered_ids, after_shuffle); // The shuffle only happens once the cursor walks // through the whole set, so `after_shuffle` should // contain every member, like `ordered_ids`, but in // a distinct order after_shuffle.sort_unstable(); assert_eq!(ordered_ids, after_shuffle); } #[test] fn apply_existing_if_behaviour() { let mut members = Members::new(Vec::new()); assert_eq!( None, members.apply_existing_if(Member::alive(Id("1")), |_member| true), "Only yield None only if member is not found" ); let mut rng = SmallRng::seed_from_u64(0xF0CA); let _ = members.apply(Member::alive(Id("1")), &mut rng); assert_ne!( None, members.apply_existing_if(Member::alive(Id("1")), |_member| true), "Must yield Some() if existing, regardless of condition" ); assert_ne!( None, members.apply_existing_if(Member::alive(Id("1")), |_member| false), "Must yield Some() if existing, regardless of condition" ); } #[test] fn apply_summary_behaviour() { let mut members = Members::new(Vec::new()); let mut rng = SmallRng::seed_from_u64(0xF0CA); // New and active member let res = members.apply(Member::suspect(Id("1")), &mut rng); assert_eq!( ApplySummary { is_active_now: true, apply_successful: true, changed_active_set: true, conflict: ConflictResult::NoConflict, }, res, ); assert_eq!(1, members.len()); assert_eq!(1, members.num_active()); // Failed attempt to change member id=1 to alive // (since it's already suspect with same incarnation) let res = members.apply(Member::alive(Id("1")), &mut rng); assert_eq!( ApplySummary { is_active_now: true, apply_successful: false, changed_active_set: false, conflict: ConflictResult::NoConflict, }, res, ); assert_eq!(1, members.len()); // Successful attempt at changing member id=1 to // alive by using a higher incarnation let res = members.apply(Member::new(Id("1"), 1, State::Alive), &mut rng); assert_eq!( ApplySummary { is_active_now: true, apply_successful: true, changed_active_set: false, conflict: ConflictResult::NoConflict, }, res, ); assert_eq!(1, members.len()); // Change existing member to down let res = members.apply(Member::down(Id("1")), &mut rng); assert_eq!( ApplySummary { is_active_now: false, apply_successful: true, changed_active_set: true, conflict: ConflictResult::NoConflict, }, res, ); assert_eq!(1, members.len()); assert_eq!(0, members.num_active()); // New and inactive member let res = members.apply(Member::down(Id("2")), &mut rng); assert_eq!( ApplySummary { is_active_now: false, apply_successful: true, changed_active_set: false, conflict: ConflictResult::NoConflict, }, res, ); assert_eq!(2, members.len()); assert_eq!(0, members.num_active()); } #[test] fn remove_if_down_works() { let mut members = Members::new(Vec::new()); let mut rng = SmallRng::seed_from_u64(0xF0CA); assert_eq!( None, members.remove_if_down(&Id("1")), "cant remove member that does not exist" ); let _ = members.apply(Member::alive(Id("1")), &mut rng); assert_eq!( None, members.remove_if_down(&Id("1")), "cant remove member that isnt down" ); let _ = members.apply(Member::down(Id("1")), &mut rng); assert_eq!( Some(Member::down(Id("1"))), members.remove_if_down(&Id("1")), "must return the removed member" ); } #[test] fn next_yields_none_with_no_active_members() { let mut members = Members::new(Vec::new()); let mut rng = SmallRng::seed_from_u64(0xF0CA); assert_eq!( None, members.next(&mut rng), "next() should yield None when there are no members" ); let _ = members.apply(Member::down(Id("-1")), &mut rng); let _ = members.apply(Member::down(Id("-2")), &mut rng); let _ = members.apply(Member::down(Id("-3")), &mut rng); assert_eq!( None, members.next(&mut rng), "next() should yield None when there are no active members" ); let _ = members.apply(Member::alive(Id("1")), &mut rng); for _i in 0..10 { assert_eq!( Some(Id("1")), members.next(&mut rng).map(|m| m.id), "next() should yield the same member if its the only active" ); } } #[test] fn choose_active_members_behaviour() { let members = Members::new(Vec::from([ // 5 active members Member::alive(Id("1")), Member::alive(Id("2")), Member::alive(Id("3")), Member::suspect(Id("4")), Member::suspect(Id("5")), // 2 down Member::down(Id("6")), Member::down(Id("7")), ])); assert_eq!(7, members.len()); assert_eq!(5, members.num_active()); let mut out = Vec::new(); let mut rng = SmallRng::seed_from_u64(0xF0CA); out.clear(); members.choose_active_members(0, &mut out, &mut rng, |_| true); assert_eq!(0, out.len(), "Can pointlessly choose 0 members"); out.clear(); members.choose_active_members(10, &mut out, &mut rng, |_| false); assert_eq!(0, out.len(), "Filtering works"); out.clear(); members.choose_active_members(members.len(), &mut out, &mut rng, |_| true); assert_eq!( members.num_active(), out.len(), "Only chooses active members" ); out.clear(); members.choose_active_members(2, &mut out, &mut rng, |_| true); assert_eq!(2, out.len(), "Respects `wanted` even if we have more"); out.clear(); members.choose_active_members(usize::MAX, &mut out, &mut rng, |&member_id| { member_id.0.parse::<usize>().expect("number") > 4 }); assert_eq!(vec![Member::suspect(Id("5"))], out); out.clear(); members.choose_down_members(3, &mut out, &mut rng); assert_eq!(2, out.len()); assert!(out.iter().any(|m| m.id == Id("7"))); assert!(out.iter().any(|m| m.id == Id("6"))); } #[test] fn sets_replaced_id_on_addr_conflict() { let id = crate::testing::ID::new(1).rejoinable(); let mut members = Members::new(Vec::from([ // 5 active members Member::alive(id), ])); let renewed = id.renew().unwrap(); let summary = members .apply_existing_if(Member::alive(renewed), |_| true) .expect("member found"); assert!(summary.apply_successful); assert_eq!(ConflictResult::Replaced(id), summary.conflict); let another = renewed.renew().unwrap(); let summary = members .apply_existing_if(Member::alive(another), |_| false) .expect("member found"); assert!(!summary.apply_successful); assert_eq!( ConflictResult::FailedCondition, summary.conflict, "must not apply if condition fails" ); // trying to go back to the past leads to // conflict resolution failure let summary = members .apply_existing_if(Member::alive(id), |_| true) .expect("member found"); assert_eq!(ConflictResult::Lost, summary.conflict,); assert!(!summary.apply_successful, "must not apply if conflict lost"); } } |